[Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
   304: true  // Underlying request is cacheable
 };
 
 /**
  * @param {!Array.<!SDK.NetworkRequest>} requests
  * @param {?Array.<!Common.ResourceType>} types
  * @param {boolean} needFullResources
  * @return {!Object.<string, !Array.<!SDK.NetworkRequest|string>>}
  */
 Audits.AuditRules.getDomainToResourcesMap = function(requests, types, needFullResources) {
+  /** @type {!Object<string, !Array<!SDK.NetworkRequest|string>>} */
   var domainToResourcesMap = {};
   for (var i = 0, size = requests.length; i < size; ++i) {
     var request = requests[i];
     if (types && types.indexOf(request.resourceType()) === -1)
       continue;
-    var parsedURL = request.url.asParsedURL();
+    var parsedURL = request.url().asParsedURL();
     if (!parsedURL)
       continue;
     var domain = parsedURL.host;
     var domainResources = domainToResourcesMap[domain];
     if (domainResources === undefined) {
-      domainResources = [];
+      domainResources = /** @type {!Array<!SDK.NetworkRequest|string>} */ ([]);
       domainToResourcesMap[domain] = domainResources;
     }
-    domainResources.push(needFullResources ? request : request.url);
+    domainResources.push(needFullResources ? request : request.url());
   }
   return domainToResourcesMap;
 };
 
 /**
  * @unrestricted
  */
 Audits.AuditRules.GzipRule = class extends Audits.AuditRule {
   constructor() {
     super('network-gzip', Common.UIString('Enable gzip compression'));
@@ skipping 13 matching lines @@
     for (var i = 0, length = requests.length; i < length; ++i) {
       var request = requests[i];
       if (request.cached() || request.statusCode === 304)
         continue;  // Do not test cached resources.
       if (this._shouldCompress(request)) {
         var size = request.resourceSize;
         if (this._isCompressed(request))
           continue;
         var savings = 2 * size / 3;
         totalSavings += savings;
-        summary.addFormatted('%r could save ~%s', request.url, Number.bytesToString(savings));
+        summary.addFormatted('%r could save ~%s', request.url(), Number.bytesToString(savings));
         result.violationCount++;
       }
     }
     if (!totalSavings) {
       callback(null);
       return;
     }
     summary.value = Common.UIString(
         'Compressing the following resources with gzip could reduce their transfer size by about two thirds (~%s):',
         Number.bytesToString(totalSavings));
@@ skipping 207 matching lines @@
       return;
     }
 
     var requestsOnBusiestHost = domainToResourcesMap[hosts[0]];
     var entry = result.addChild(
         Common.UIString(
             'This page makes %d parallelizable requests to %s. Increase download parallelization by distributing the following requests across multiple hostnames.',
             busiestHostResourceCount, hosts[0]),
         true);
     for (var i = 0; i < requestsOnBusiestHost.length; ++i)
-      entry.addURL(requestsOnBusiestHost[i].url);
+      entry.addURL(requestsOnBusiestHost[i].url());
 
     result.violationCount = requestsOnBusiestHost.length;
     callback(result);
   }
 };
 
 /**
  * @unrestricted
  */
 Audits.AuditRules.UnusedCssRule = class extends Audits.AuditRule {
@@ skipping 331 matching lines @@
    * @param {!SDK.NetworkRequest} request
    * @return {boolean}
    */
   isPubliclyCacheable(request) {
     if (this._isExplicitlyNonCacheable(request))
       return false;
 
     if (this.responseHeaderMatch(request, 'Cache-Control', 'public'))
       return true;
 
-    return request.url.indexOf('?') === -1 && !this.responseHeaderMatch(request, 'Cache-Control', 'private');
+    return request.url().indexOf('?') === -1 && !this.responseHeaderMatch(request, 'Cache-Control', 'private');
   }
 
   /**
    * @param {!SDK.NetworkRequest} request
    * @param {string} header
    * @param {string} regexp
    * @return {?Array.<string>}
    */
   responseHeaderMatch(request, header, regexp) {
     return request.responseHeaderValue(header) ? request.responseHeaderValue(header).match(new RegExp(regexp, 'im')) :
                                                  null;
   }
 
   /**
    * @param {!SDK.NetworkRequest} request
    * @return {boolean}
    */
   hasExplicitExpiration(request) {
     return this.hasResponseHeader(request, 'Date') &&
         (this.hasResponseHeader(request, 'Expires') || !!this.responseHeaderMatch(request, 'Cache-Control', 'max-age'));
   }
 
   /**
    * @param {!SDK.NetworkRequest} request
    * @return {boolean}
    */
   _isExplicitlyNonCacheable(request) {
     var hasExplicitExp = this.hasExplicitExpiration(request);
-    return !!this.responseHeaderMatch(request, 'Cache-Control', '(no-cache|no-store)') ||
+    return !!(
+        !!this.responseHeaderMatch(request, 'Cache-Control', '(no-cache|no-store)') ||
         !!this.responseHeaderMatch(request, 'Pragma', 'no-cache') ||
         (hasExplicitExp && !this.freshnessLifetimeGreaterThan(request, 0)) ||
-        (!hasExplicitExp && !!request.url && request.url.indexOf('?') >= 0) ||
-        (!hasExplicitExp && !this.isCacheableResource(request));
+        (!hasExplicitExp && request.url() && request.url().indexOf('?') >= 0) ||
+        (!hasExplicitExp && !this.isCacheableResource(request)));
   }
 
   /**
    * @param {!SDK.NetworkRequest} request
    * @return {boolean}
    */
   isCacheableResource(request) {
     return request.statusCode !== undefined && Audits.AuditRules.CacheableResponseCodes[request.statusCode];
   }
 };
@@ skipping 727 matching lines @@
   }
 
   processCookies(allCookies, requests, result) {
     var domainToResourcesMap = Audits.AuditRules.getDomainToResourcesMap(
         requests, [Common.resourceTypes.Stylesheet, Common.resourceTypes.Image], true);
     var totalStaticResources = 0;
     for (var domain in domainToResourcesMap)
       totalStaticResources += domainToResourcesMap[domain].length;
     if (totalStaticResources < this._minResources)
       return;
+    /** @type {!Object<string, number>} */
     var matchingResourceData = {};
     this.mapResourceCookies(domainToResourcesMap, allCookies, this._collectorCallback.bind(this, matchingResourceData));
 
     var badUrls = [];
     var cookieBytes = 0;
     for (var url in matchingResourceData) {
       badUrls.push(url);
       cookieBytes += matchingResourceData[url];
     }
     if (badUrls.length < this._minResources)
       return;
 
     var entry = result.addChild(
         Common.UIString(
             '%s of cookies were sent with the following static resources. Serve these static resources from a domain that does not set cookies:',
             Number.bytesToString(cookieBytes)),
         true);
     entry.addURLs(badUrls);
     result.violationCount = badUrls.length;
   }
 
+  /**
+   * @param {!Object<string, number>} matchingResourceData
+   * @param {!SDK.NetworkRequest} request
+   * @param {!SDK.Cookie} cookie
+   */
   _collectorCallback(matchingResourceData, request, cookie) {
-    matchingResourceData[request.url] = (matchingResourceData[request.url] || 0) + cookie.size();
+    matchingResourceData[request.url()] = (matchingResourceData[request.url()] || 0) + cookie.size();
   }
 };