third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2626543002: Handle ES3 Sampler types in getUniform in WebGL2RenderingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2626543002: Handle ES3 Sampler types in getUniform in WebGL2RenderingContext (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 51e311d30217cd72e6429c1d5349f38924243d84..d104aa45614020a1d63cbea5aed52fcdbd774607 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -3614,6 +3614,17 @@ ScriptValue WebGLRenderingContextBase::getUniform(

break;

case GL_SAMPLER_3D:

case GL_SAMPLER_2D_ARRAY:

+ case GL_SAMPLER_2D_SHADOW:

+ case GL_SAMPLER_CUBE_SHADOW:

+ case GL_SAMPLER_2D_ARRAY_SHADOW:

+ case GL_INT_SAMPLER_2D:

+ case GL_INT_SAMPLER_CUBE:

+ case GL_INT_SAMPLER_3D:

+ case GL_INT_SAMPLER_2D_ARRAY:

+ case GL_UNSIGNED_INT_SAMPLER_2D:

+ case GL_UNSIGNED_INT_SAMPLER_CUBE:

+ case GL_UNSIGNED_INT_SAMPLER_3D:

+ case GL_UNSIGNED_INT_SAMPLER_2D_ARRAY:

baseType = GL_INT;

length = 1;

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »