Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 2626533002: Revert of Fix getUserMedia so that failure is reported for invalid audio sources. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler_unittest.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler_unittest.cc b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
index 680d16d153f48cb2cea39f05f98b8fad0e785d73..7745960a5b00f8546734770256b27d322032f005 100644
--- a/content/renderer/media/rtc_peer_connection_handler_unittest.cc
+++ b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
@@ -296,10 +296,10 @@
media::AudioParameters::kAudioCDSampleRate,
media::CHANNEL_LAYOUT_STEREO,
media::AudioParameters::kAudioCDSampleRate / 100),
- MockConstraintFactory().CreateWebMediaConstraints(),
- base::Bind(&RTCPeerConnectionHandlerTest::OnAudioSourceStarted),
mock_dependency_factory_.get());
audio_source->SetAllowInvalidRenderFrameIdForTesting(true);
+ audio_source->SetSourceConstraints(
+ MockConstraintFactory().CreateWebMediaConstraints());
blink_audio_source.setExtraData(audio_source); // Takes ownership.
blink::WebMediaStreamSource video_source;
@@ -365,10 +365,6 @@
for (const auto& track : video_tracks)
MediaStreamVideoTrack::GetVideoTrack(track)->Stop();
}
-
- static void OnAudioSourceStarted(MediaStreamSource* source,
- MediaStreamRequestResult result,
- const blink::WebString& result_name) {}
base::MessageLoop message_loop_;
std::unique_ptr<ChildProcess> child_process_;
« no previous file with comments | « content/renderer/media/local_media_stream_audio_source.cc ('k') | content/renderer/media/user_media_client_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698