Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 262653004: Change the text of the Apps Developer Tools Promo (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Change the text of the Apps Developer Tools Promo UI/Strings requested a change to be "Try the new <a>Chrome Apps & Extensions Developer Tools</a>." BUG=312396 TBR=finnur@chromium.org (for changes to strings in extension_settings_handler) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267987

Patch Set 1 : #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.css View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
6 years, 7 months ago (2014-05-02 21:41:55 UTC) #1
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-02 21:44:44 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-02 22:13:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/262653004/40001
6 years, 7 months ago (2014-05-02 22:14:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 22:42:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium
6 years, 7 months ago (2014-05-02 22:42:20 UTC) #6
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-02 22:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/262653004/40001
6 years, 7 months ago (2014-05-02 22:49:10 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 00:24:48 UTC) #9
Message was sent while issue was closed.
Change committed as 267987

Powered by Google App Engine
This is Rietveld 408576698