Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 262653002: When maximum space size flags are set, overwrite the resource constraints. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

When maximum space size flags are set, overwrite the resource constraints. BUG= R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21102

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/heap.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
6 years, 7 months ago (2014-04-30 11:54:30 UTC) #1
rmcilroy
https://codereview.chromium.org/262653002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/262653002/diff/1/src/api.cc#newcode474 src/api.cc:474: Would it be better to put this code in ...
6 years, 7 months ago (2014-04-30 12:17:13 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/262653002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/262653002/diff/1/src/api.cc#newcode474 src/api.cc:474: On 2014/04/30 12:17:13, rmcilroy wrote: > Would it be ...
6 years, 7 months ago (2014-04-30 12:36:22 UTC) #3
rmcilroy
lgtm - thanks!
6 years, 7 months ago (2014-04-30 12:56:57 UTC) #4
Hannes Payer (out of office)
6 years, 7 months ago (2014-04-30 18:13:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698