Cronet: a framework for providing alternative Cronet implementations

components/cronet/android/api/src/org/chromium/net/CronetImplProvider.java

Index: components/cronet/android/api/src/org/chromium/net/CronetImplProvider.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetImplProvider.java b/components/cronet/android/api/src/org/chromium/net/CronetImplProvider.java
new file mode 100644
index 0000000000000000000000000000000000000000..c5feb8e6de7bdae34ce622f9bd1a3013aa56f6f3
--- /dev/null
+++ b/components/cronet/android/api/src/org/chromium/net/CronetImplProvider.java
@@ -0,0 +1,38 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;
+
+import android.content.Context;
+
+/**
+ * A Cronet implementation provider.
+ *
+ * {@hide not part of the official API}
+ */
+public abstract class CronetImplProvider {

[mef, 2017/01/10 23:30:03]

nit: Maybe CronetProvider or CronetLoader?

[kapishnikov, 2017/01/17 22:29:20]

Done.

+    /**
+     * Loads implementation of {@code ICronetEngineBuilder}.
+     *
+     * @param context Android {@link Context} to use for loading.
+     * @return {@code ICronetEngineBuilder} implementation.
+     */
+    protected abstract ICronetEngineBuilder load(Context context);

[pauljensen, 2017/01/11 16:48:13]

rather than having every call take Context, can we add a constructor that takes
a Context and a mContext protected member?

[kapishnikov, 2017/01/17 22:29:20]

Done.

+
+    /**
+     * Returns the provider name.
+     *
+     * @param context application context.
+     * @return provider name.
+     */
+    protected abstract String getName(Context context);

[pauljensen, 2017/01/11 16:48:13]

What's the name used for?  can we remove it?  we'll log the name for the
selected engine later using CronetEngine.getVersionString().

[kapishnikov, 2017/01/17 22:29:20]

The name can be used by embedders to select the provider that should be used.

+
+    /**
+     * Returns the provider version.
+     *
+     * @param context application context.
+     * @return provider version.
+     */
+    protected abstract String getVersion(Context context);
+}