Cronet: a framework for providing alternative Cronet implementations

components/cronet/android/java/src/org/chromium/net/impl/JavaCronetProvider.java

Index: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetProvider.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetProvider.java b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetProvider.java
new file mode 100644
index 0000000000000000000000000000000000000000..ae728e42d30f9d72dcb740e15f803ad6919f9ebf
--- /dev/null
+++ b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetProvider.java
@@ -0,0 +1,50 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net.impl;
+
+import android.content.Context;
+
+import org.chromium.net.CronetEngine;
+import org.chromium.net.CronetProvider;
+import org.chromium.net.ExperimentalCronetEngine;
+import org.chromium.net.ICronetEngineBuilder;
+
+/**
+ * Implementation of {@link CronetProvider} that creates {@link CronetEngine.Builder}
+ * for building the Java-base implementation of {@link CronetEngine}.
+ */
+public class JavaCronetProvider extends CronetProvider {
+    public static final String PROVIDER_NAME = "Platform-Cronet-Provider";

[pauljensen, 2017/01/18 17:03:05]

Can we make it clearer that this is not the full-fledged native impl with the
performance everyone expects, perhaps "FallbackPlatformBased" or
"LowerPerformancePlatformBased".  I don't think we need to include
"Cronet-Provider" in the name; it seems redundant with the class name.

[pauljensen, 2017/01/18 17:03:05]

private?

[kapishnikov, 2017/01/19 01:25:24]

Done.

[kapishnikov, 2017/01/19 01:25:24]

I think the embedder should use the name of the provider instead of the class
name when choosing providers. I added the well-known names to the
CornetProviders class as public constants. Not sure it should be called
FallbackPlatformBased since some apps/libraries may use it as the primary
provider due to the size. It shouldn't matter much since the embedder should use
public constants.

This is an internal class. We should document somewhere else regarding the
benefits and disadvantages of including one or other provider.

+
+    /**
+     * Constructor.
+     *
+     * @param context Android context to use.
+     */
+    public JavaCronetProvider(Context context) {
+        super(context);
+    }
+
+    @Override
+    public CronetEngine.Builder createBuilder() {
+        ICronetEngineBuilder impl = new JavaCronetEngineBuilder(mContext);
+        return new ExperimentalCronetEngine.Builder(impl);
+    }
+
+    @Override
+    public String getName() {
+        return PROVIDER_NAME;
+    }
+
+    @Override
+    public String getVersion() {
+        return ImplVersion.getCronetVersion();
+    }
+
+    @Override
+    public boolean isEnabled() {
+        return true;
+    }
+}