Cronet: a framework for providing alternative Cronet implementations

components/cronet/android/api/src/org/chromium/net/CronetProvider.java

Index: components/cronet/android/api/src/org/chromium/net/CronetProvider.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetProvider.java b/components/cronet/android/api/src/org/chromium/net/CronetProvider.java
new file mode 100644
index 0000000000000000000000000000000000000000..f0a98f8d420260eef429847a56c3f196037122bc
--- /dev/null
+++ b/components/cronet/android/api/src/org/chromium/net/CronetProvider.java
@@ -0,0 +1,47 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;
+
+import android.content.Context;
+
+/**
+ * A Cronet implementation provider. Note: every implementation of CronetProvider
+ * must have a public constructor that accepts a single {@link Context} parameter.

[pauljensen, 2017/01/18 17:03:04]

what about prefacing this with something like:

<b>NOTE:</b> This class is for advanced users that want to select a particular
Cronet implementation.  Most users should simply use {@code new} {@link
CronetEngine.Builder#Builder}.
<p>

[kapishnikov, 2017/01/19 01:25:24]

Done.

+ */
+public abstract class CronetProvider {
+    protected final Context mContext;
+
+    protected CronetProvider(Context context) {
+        mContext = context;
+    }
+
+    /**
+     * Creates and returns {@link CronetEngine.Builder}.
+     *
+     * @return {@code CronetEngine.Builder}.
+     */
+    public abstract CronetEngine.Builder createBuilder();
+
+    /**
+     * Returns the provider name.
+     *
+     * @return provider name.
+     */
+    public abstract String getName();
+
+    /**
+     * Returns the provider version.
+     *
+     * @return provider version.
+     */
+    public abstract String getVersion();
+
+    /**
+     * Returns whether the provider is enabled and can be used to instantiate the Cronet engine.
+     *
+     * @return true if the provider is available.

[mef, 2017/01/18 20:57:54]

nit: s/available/enabled/.

[kapishnikov, 2017/01/19 01:25:24]

Done.

+     */
+    public abstract boolean isEnabled();
+}