components/cronet/android/cronet_impl_platform_proguard.cfg - Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/cronet_impl_platform_proguard.cfg

Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations (Closed)

Patch Set: Addressed Paul's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Proguard config for apps that depend on cronet_impl_platform_java.jar.	1 # Proguard config for apps that depend on cronet_impl_platform_java.jar.

2	2

3 # This constructor is called using the reflection from the Cronet common	3 # This constructor is called using the reflection from Cronet API (cronet_api.ja r).

4 # implementation (cronet_impl_platform_java.jar).	4 -keep class org.chromium.net.impl.JavaCronetProvider {

5 -keep class org.chromium.net.impl.JavaCronetEngine {	5 public <init>(android.content.Context);

6 public <init>(java.lang.String);

7 }	6 }
	pauljensen 2017/01/23 19:42:22 nit: can we instead do this via @UsedByReflection nit: can we instead do this via @UsedByReflection in the source? kapishnikov 2017/01/23 22:14:55 Only cronet_impl_native_proguard.cfg contains "-ke Show quoted text On 2017/01/23 19:42:22, pauljensen wrote: > nit: can we instead do this via @UsedByReflection in the source? Only cronet_impl_native_proguard.cfg contains "-keep" for classes annotated by @UsedByReflection. Also, the annotation lives in org.chromium.base.annotations.UsedByReflection and we do not want to introduce that dependency to the Java engine.
OLD	NEW