components/cronet/android/cronet_impl_native_proguard.cfg - Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations

Side by Side Diff: components/cronet/android/cronet_impl_native_proguard.cfg

Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations (Closed)

Patch Set: Addressed Paul's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« components/cronet/android/cronet_impl_common_proguard.cfg ('K') | « components/cronet/android/cronet_impl_common_proguard.cfg ('k') | components/cronet/android/cronet_impl_platform_proguard.cfg » ('j') | components/cronet/android/cronet_impl_platform_proguard.cfg » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Proguard config for apps that depend on cronet_impl_native_java.jar.	1 # Proguard config for apps that depend on cronet_impl_native_java.jar.

2	2

	3 # This constructor is called using the reflection from Cronet API (cronet_api.ja r).

	4 -keep class org.chromium.net.impl.NativeCronetProvider {

	5 public <init>(android.content.Context);

	6 }
	pauljensen 2017/01/23 19:42:22 nit: can we instead do this via @UsedByReflection nit: can we instead do this via @UsedByReflection in the source? kapishnikov 2017/01/23 22:14:55 Good suggestion. Done. Show quoted text On 2017/01/23 19:42:22, pauljensen wrote: > nit: can we instead do this via @UsedByReflection in the source? Good suggestion. Done.
	7

3 # Suppress unnecessary warnings.	8 # Suppress unnecessary warnings.

4 -dontnote org.chromium.net.ProxyChangeListener$ProxyReceiver	9 -dontnote org.chromium.net.ProxyChangeListener$ProxyReceiver

5 -dontnote org.chromium.net.AndroidKeyStore	10 -dontnote org.chromium.net.AndroidKeyStore

6 # Needs 'void setTextAppearance(int)' (API level 23).	11 # Needs 'void setTextAppearance(int)' (API level 23).

7 -dontwarn org.chromium.base.ApiCompatibilityUtils	12 -dontwarn org.chromium.base.ApiCompatibilityUtils

8 # Needs 'boolean onSearchRequested(android.view.SearchEvent)' (API level 23).	13 # Needs 'boolean onSearchRequested(android.view.SearchEvent)' (API level 23).

9 -dontwarn org.chromium.base.WindowCallbackWrapper	14 -dontwarn org.chromium.base.WindowCallbackWrapper

10	15

11 # Generated for chrome apk and not included into cronet.	16 # Generated for chrome apk and not included into cronet.

12 -dontwarn org.chromium.base.BuildConfig	17 -dontwarn org.chromium.base.BuildConfig

13 -dontwarn org.chromium.base.library_loader.NativeLibraries	18 -dontwarn org.chromium.base.library_loader.NativeLibraries

14 -dontwarn org.chromium.base.multidex.ChromiumMultiDexInstaller	19 -dontwarn org.chromium.base.multidex.ChromiumMultiDexInstaller

15	20

16 # Objects of this type are passed around by native code, but the class	21 # Objects of this type are passed around by native code, but the class

17 # is never used directly by native code. Since the class is not loaded, it does	22 # is never used directly by native code. Since the class is not loaded, it does

18 # not need to be preserved as an entry point.	23 # not need to be preserved as an entry point.

19 -dontnote org.chromium.net.UrlRequest$ResponseHeadersMap	24 -dontnote org.chromium.net.UrlRequest$ResponseHeadersMap

20 # https://android.googlesource.com/platform/sdk/+/marshmallow-mr1-release/files/ proguard-android.txt#54	25 # https://android.googlesource.com/platform/sdk/+/marshmallow-mr1-release/files/ proguard-android.txt#54

21 -dontwarn android.support.**	26 -dontwarn android.support.**

22	27

23 # This class should be explicitly kept to avoid failure if	28 # This class should be explicitly kept to avoid failure if

24 # class/merging/horizontal proguard optimization is enabled.	29 # class/merging/horizontal proguard optimization is enabled.

25 -keep class org.chromium.base.CollectionUtil	30 -keep class org.chromium.base.CollectionUtil

26	31

OLD	NEW