Cronet: a framework for providing alternative Cronet implementations

components/cronet/android/test/proguard.cfg

 # Proguard configuration that is common for all type of tests.
 
 -keepattributes Signature,InnerClasses,SourceFile,LineNumberTable
 -dontwarn io.netty.**
 -keep class io.netty.** { *; }
 -keep class org.chromium.net.smoke.ChromiumNativeTestSupport
 -keep class org.chromium.net.smoke.ChromiumPlatformOnlyTestSupport

[pauljensen, 2017/01/20 17:13:36]

why are these two lines needed?  can you add a comment?

[kapishnikov, 2017/01/20 21:48:39]

Added comment;
# Keep ChromiumNativeTestSupport & ChromiumPlatformOnlyTestSupport since they
are
# instantiated through Reflection by the smoke tests.

 
 # TODO(jbudorick): Remove when crbug.com/488192 is fixed.
 -dontwarn org.apache.http.**
 
 -dontwarn android.support.test.runner.MonitoringInstrumentation
 
+# Do not obfuscate this class for testing since some of the tests check the class
+# name in order to check that an instantiated engine is the Java one.
+-keep class org.chromium.net.impl.JavaCronetEngine

[pauljensen, 2017/01/20 17:13:36]

Instead of checking the name, why not just do "instanceof JavaCronetEngine"? 
Then we can remove this proguard line...which kinda scares me.

[kapishnikov, 2017/01/20 21:48:39]

This is a good point. Currently smoke tests only rely on the API, i.e. they
don't require the implementation part to compile. The implementation part is
included when the app is linked. That is the realization of the idea that the
client code can compile without including any implementation jars and at the app
packaging stage the embedder can decide what implementations to package. I
changed "-keep" to "-keepnames".

+
 # These classes should be explicitly kept to avoid failure if
 # class/merging/horizontal proguard optimization is enabled.
 # NOTE: make sure that only test classes are added to this list.
 -keep class org.chromium.base.test.util.**
 -keep class org.chromium.net.TestFilesInstaller
 -keep class org.chromium.net.MetricsTestUtil