components/cronet/android/cronet_impl_common_proguard.cfg - Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/cronet_impl_common_proguard.cfg

Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations (Closed)

Patch Set: Updated api.txt Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/cronet/android/api/src/org/chromium/net/CronetProviders.java ('K') | « components/cronet/android/api_version.txt ('k') | components/cronet/android/cronet_impl_native_proguard.cfg » ('j') | components/cronet/android/java/src/org/chromium/net/impl/JavaCronetProvider.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Proguard config for apps that depend on cronet_impl_common_java.jar.	1 # Proguard config for apps that depend on cronet_impl_common_java.jar.

2	2

3 # This constructor is called using the reflection from Cronet API (cronet_api.ja r).

4 -keep class org.chromium.net.impl.CronetEngineBuilderImpl {

5 public <init>(android.content.Context);

6 }

7

8 # This class should be explicitly kept to avoid failure if	3 # This class should be explicitly kept to avoid failure if

9 # class/merging/horizontal proguard optimization is enabled.	4 # class/merging/horizontal proguard optimization is enabled.

10 -keep class org.chromium.net.impl.ImplVersion	5 -keep class org.chromium.net.impl.ImplVersion

	6

	7 # Do not obfuscate this class for testing since some of the tests check the clas s

	8 # name in order to check that an instantiated engine is the Java one.

	9 -keep class org.chromium.net.impl.JavaCronetEngine
	pauljensen 2017/01/18 17:03:04 Our production proguard files shouldn't have testi Our production proguard files shouldn't have testing references if possible. Can we change our tests to simply use "instanceof JavaCronetEngine"? kapishnikov 2017/01/19 01:25:24 Agree. I actually wanted to add it to the test pro Show quoted text On 2017/01/18 17:03:04, pauljensen wrote: > Our production proguard files shouldn't have testing references if possible. > Can we change our tests to simply use "instanceof JavaCronetEngine"? Agree. I actually wanted to add it to the test proguard. One concern is that the test will not check whether removing this "keep" will break anything in production.
OLD	NEW