Improve MediaPlayerBridge seek resiliance

Improve MediaPlayerBridge seek resiliance

crbug.com/677280 manifested whenever we tried seeking on a non-seekable
live stream, causing the MediaPlayer to crash, and the stream to never
start.

Dropping seeks based off of unknown or infinite media duration (for
livestreams) introduced crbug.com/679482. When we resume a tab, the
MediaPlayerRenderer is re-created, and if the preliminary attempt to
extract the media's metadata failed, we drop the first seek. This causes
the media restart after every tab switch.

It turns out that there is a better fix for 677280, which prevents
679482 entirely. Currently, in MediaPlayerBridge::OnMediaPrepared(), we
complete pending seeks before updating allowable operations. Updating
allowable operations as a first action properly sets "CanSeekForward"
and "CanSeekBackards", which then aborts any invalid seek attempts
without any additional logic.

BUG=679482, 677280
TEST= Manual test on a live HLS stream and non live HLS video.

[tguilbert, 2017-01-09 23:21:07]

tguilbert@chromium.org changed reviewers:
+ sandersd@chromium.org

[tguilbert, 2017-01-09 23:21:07]

PTAL. This is a follow-up/correction to yesterday's CL.

[sandersd (OOO until July 31), 2017-01-09 23:34:35]

lgtm

[tguilbert, 2017-01-09 23:35:40]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:31:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484004940892130, "parent_rev":
"9bb8cf24e8585342e57493dea8acc31772f48438", "commit_rev":
"0d32da520686f09a43107b63e9ab365fa5af580f"}

[commit-bot: I haz the power, 2017-01-10 01:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:40:40]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[tguilbert, 2017-01-10 19:06:31]

On 2017/01/10 01:40:40, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

This was committed successfully as 0d32da520686f09a43107b63e9ab365fa5af580f.
Closing this issue.

[tguilbert, 2017-01-10 19:06:49]

Description was changed from

==========
Improve MediaPlayerBridge seek resiliance

crbug.com/677280 manifested whenever we tried seeking on a non-seekable
live stream, causing the MediaPlayer to crash, and the stream to never
start.

Dropping seeks based off of unknown or infinite media duration (for
livestreams) introduced crbug.com/679482. When we resume a tab, the
MediaPlayerRenderer is re-created, and if the preliminary attempt to
extract the media's metadata failed, we drop the first seek. This causes
the media restart after every tab switch.

It turns out that there is a better fix for 677280, which prevents
679482 entirely. Currently, in MediaPlayerBridge::OnMediaPrepared(), we
complete pending seeks before updating allowable operations. Updating
allowable operations as a first action properly sets "CanSeekForward"
and "CanSeekBackards", which then aborts any invalid seek attempts
without any additional logic.

BUG=679482, 677280
TEST= Manual test on a live HLS stream and non live HLS video.
==========

to

==========
Improve MediaPlayerBridge seek resiliance

crbug.com/677280 manifested whenever we tried seeking on a non-seekable
live stream, causing the MediaPlayer to crash, and the stream to never
start.

Dropping seeks based off of unknown or infinite media duration (for
livestreams) introduced crbug.com/679482. When we resume a tab, the
MediaPlayerRenderer is re-created, and if the preliminary attempt to
extract the media's metadata failed, we drop the first seek. This causes
the media restart after every tab switch.

It turns out that there is a better fix for 677280, which prevents
679482 entirely. Currently, in MediaPlayerBridge::OnMediaPrepared(), we
complete pending seeks before updating allowable operations. Updating
allowable operations as a first action properly sets "CanSeekForward"
and "CanSeekBackards", which then aborts any invalid seek attempts
without any additional logic.

BUG=679482, 677280
TEST= Manual test on a live HLS stream and non live HLS video.
==========