Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: net/quic/test_tools/failing_proof_source.cc

Issue 2626443002: Fix QUIC crash when ProofSource::GetProof fails (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/quic/test_tools/failing_proof_source.h"
6
7 namespace net {
8 namespace test {
9
10 bool FailingProofSource::GetProof(
11 const QuicSocketAddress& server_address,
12 const std::string& hostname,
13 const std::string& server_config,
14 QuicVersion quic_version,
15 base::StringPiece chlo_hash,
16 const QuicTagVector& connection_options,
17 QuicReferenceCountedPointer<ProofSource::Chain>* out_chain,
18 QuicCryptoProof* out_proof) {
19 return false;
Jana 2017/01/09 22:08:08 Can you not just do this in the .h file as in the
danzh1 2017/01/09 22:20:42 Yes, chromium compiler failed in my local repo. An
20 }
21
22 void FailingProofSource::GetProof(const QuicSocketAddress& server_address,
23 const std::string& hostname,
24 const std::string& server_config,
25 QuicVersion quic_version,
26 base::StringPiece chlo_hash,
27 const QuicTagVector& connection_options,
28 std::unique_ptr<Callback> callback) {
29 callback->Run(false, nullptr, QuicCryptoProof(), nullptr);
30 }
31
32 } // namespace test
33 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/test_tools/failing_proof_source.h ('k') | net/quic/test_tools/quic_crypto_server_config_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698