Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 262643003: Revert of Refactor views app list services to allow more code sharing (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Refactor views app list services to allow more code sharing (https://codereview.chromium.org/225053004/) Reason for revert: failed compile on clang dbg. Overriding method must be marked with OVERRIDE. virtual app_list::AppListView* MakeViewForCurrentProfile() { Overriding method must be marked with OVERRIDE. virtual AppListControllerDelegate* GetControllerDelegateForCreate() { Original issue's description: > Refactor views app list services to allow more code sharing > > To run the toolkit-views app launcher on Mac, it needs a new app list > service + supporting classes. It's going to look a lot like the Linux > one. This CL starts by sharing what can be shared between Windows and > Linux, in preparation for using it on Mac as well. > > It does this principally by: > - Moving `app_list_shower` to `app_list_shower_views`, making it views-specific; > - Adding AppListServiceViews, which Win/Linux (and soon Mac) inherit from; > - Rearranging the delegation to eliminate some boilerplate. > > Other changes: > - Removed AppList container abstract interface (now just access AppListView); > - Removed AppListFactory (now AppListShower::MakeViewForCurrentProfile()); > - Moved AppListControllerDelegateLinux to AppListControllerDelegateViews; > - Most of AppListServiceLinux moves to AppListServiceViews; > - Added AppListShowerDelegate and AppListShower given virtual method > hooks to assist testability (previously AppListShower was given a NULL > service/delegate in tests); > - Positioning logic in AppListWin/AppListLinux made static/stateless; > - Removes the `on_should_dismiss_` closure (now just dismiss via the service; > - Big trim of AppListServiceWin and AppListServiceLinux - now these are > just platform-specific stuff. > > BUG=365977 > TEST=Just refactoring, nothing should change > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267184 TBR=tapted@chromium.org,mgiuca@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+922 lines, -729 lines) Patch
A chrome/browser/ui/app_list/app_list.h View 1 chunk +26 lines, -0 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_controller_delegate_views.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_controller_delegate_views.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_factory.h View 1 chunk +27 lines, -0 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_views.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_views.cc View 1 chunk +0 lines, -71 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_shower.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_shower.cc View 1 chunk +102 lines, -0 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_shower_delegate.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_shower_views.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_shower_views.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_shower_views_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
A chrome/browser/ui/app_list/test/app_list_shower_unittest.cc View 1 chunk +166 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/app_list/linux/app_list_controller_delegate_linux.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/app_list/linux/app_list_controller_delegate_linux.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.h View 3 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.cc View 3 chunks +62 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_service_linux.h View 1 chunk +21 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc View 3 chunks +92 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/activation_tracker_win.h View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/activation_tracker_win.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.h View 1 chunk +19 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.cc View 2 chunks +21 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.h View 2 chunks +21 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 8 chunks +95 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.h View 2 chunks +29 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.cc View 3 chunks +45 lines, -7 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tapted
Created Revert of Refactor views app list services to allow more code sharing
6 years, 7 months ago (2014-04-30 11:57:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/262643003/1
6 years, 7 months ago (2014-04-30 11:57:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 11:57:14 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-04-30 11:57:15 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-04-30 12:04:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/262643003/1
6 years, 7 months ago (2014-04-30 12:04:56 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 12:05:40 UTC) #7
Message was sent while issue was closed.
Change committed as 267191

Powered by Google App Engine
This is Rietveld 408576698