third_party/WebKit/Source/core/frame/History.cpp - Issue 2626423003: Use DOMWindowClient for objects owned by LocalDOMWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/History.cpp

Issue 2626423003: Use DOMWindowClient for objects owned by LocalDOMWindow (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/History.cpp

diff --git a/third_party/WebKit/Source/core/frame/History.cpp b/third_party/WebKit/Source/core/frame/History.cpp

index 5e7305238896f149db31e235ac414ad2462330ac..a1dd7e7bf88eb08eb0807f1148009002701d23ea 100644

--- a/third_party/WebKit/Source/core/frame/History.cpp

+++ b/third_party/WebKit/Source/core/frame/History.cpp

@@ -57,10 +57,10 @@ bool equalIgnoringQueryAndFragment(const KURL& a, const KURL& b) {

} // namespace

History::History(LocalFrame* frame)

- : ContextClient(frame), m_lastStateObjectRequested(nullptr) {}

+ : DOMWindowClient(frame), m_lastStateObjectRequested(nullptr) {}

DEFINE_TRACE(History) {

- ContextClient::trace(visitor);

+ DOMWindowClient::trace(visitor);

}

unsigned History::length() const {