Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java

Issue 2626413004: Bind Android ChildProcessServices to a specific client PID. (Closed)
Patch Set: Add OWNERS file Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
index 8f935906aa8d02c5e1c75895d36c3709f3597d86..5010aa96c61a50b2eb5d0e3b6d492514dad22349 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
@@ -27,6 +27,24 @@ public interface ChildProcessConnection {
}
/**
+ * Used to notify the consumer about the process start. These callbacks will be invoked before
+ * the ConnectionCallbacks.
+ */
+ interface StartCallback {
+ /**
+ * Called when the child process has successfully started and is ready for connection
+ * setup.
+ */
+ void onChildStarted();
+
+ /**
+ * Called when the child process failed to start. This can happen if the process is already
+ * in use by another client.
+ */
+ void onChildStartFailed();
+ }
+
+ /**
* Used to notify the consumer about the connection being established.
*/
interface ConnectionCallback {
@@ -57,8 +75,9 @@ public interface ChildProcessConnection {
* remainder later while reducing the connection setup latency.
* @param commandLine (optional) command line for the child process. If omitted, then
* the command line parameters must instead be passed to setupConnection().
+ * @param startCallback (optional) callback when the child process starts or fails to start.
*/
- void start(String[] commandLine);
+ void start(String[] commandLine, StartCallback startCallback);
/**
* Setups the connection after it was started with start().

Powered by Google App Engine
This is Rietveld 408576698