telemetry/telemetry/page/shared_page_state.py - Issue 2626373004: [WPR] Implement platform dependent recordings for WPR archives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 2626373004: [WPR] Implement platform dependent recordings for WPR archives. (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/shared_page_state.py

diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py

index 45c6506de500f152187c645a3e3ffb2f070d6f8f..b67efa27ce56485d5d4d636739d3b3d5d47c9aee 100644

--- a/telemetry/telemetry/page/shared_page_state.py

+++ b/telemetry/telemetry/page/shared_page_state.py

@@ -198,7 +198,7 @@ class SharedPageState(story.SharedState):

self._StopBrowser()

started_browser = not self.browser

- archive_path = page_set.WprFilePathForStory(page)

+ archive_path = page_set.WprFilePathForStory(page, self.platform.GetOSName())

# TODO(nednguyen, perezju): Ideally we should just let the network

# controller raise an exception when the archive_path is not found.

if archive_path is not None and not os.path.isfile(archive_path):

« no previous file with comments | « telemetry/telemetry/page/__init__.py ('k') | telemetry/telemetry/story/story.py » ('j') | no next file with comments »