Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2626343002: 1. Added new flag verify_gc_contains and moved all the asserts that do a (Closed)

Created:
3 years, 11 months ago by siva
Modified:
3 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

1. Added new flag verify_gc_contains and moved all the asserts that do a heap contains verification under it. This flag is turned on automatically when verify_before_gc, verify_after_gc or verify_on_transition is specified. This should speed up the debug builds on the bot. A dart2js build line for instance goes from 2357.526 seconds to 184.22 seconds 2. Verify heap on shutdown only under the flag verify_on_transition. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/793e4b89e65176b321e6baf07e42662671188cc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M runtime/vm/dart.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/gc_marker.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/pages.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/scavenger.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 11 months ago (2017-01-12 22:13:44 UTC) #2
Florian Schneider
LGtm
3 years, 11 months ago (2017-01-12 22:23:54 UTC) #3
siva
3 years, 11 months ago (2017-01-13 00:03:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
793e4b89e65176b321e6baf07e42662671188cc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698