Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2626333002: (Android) make ContextMenu for links / images more clear and organized (Closed)

Created:
3 years, 11 months ago by marcin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, JJ
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Android) make ContextMenu more clear and organized Bug contains more detailed description (+ screenshots) BUG=680673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 2 chunks +24 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java View 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/UrlUtilities.java View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
marcin
3 years, 11 months ago (2017-01-12 21:26:41 UTC) #4
marcin
Hi Miguel, Can I kindly ask for review ? Best Regards, Marcin
3 years, 11 months ago (2017-01-16 20:11:20 UTC) #5
marcin
Hello, Patch was originally assigned to Miguel, but unfortunately it looks, that he is unavailable. ...
3 years, 11 months ago (2017-01-17 18:17:16 UTC) #7
gone
Holding off on reviewing this until you've discussed this and gotten approval from UX. I've ...
3 years, 11 months ago (2017-01-17 18:37:29 UTC) #8
marcin
On 2017/01/17 18:37:29, dfalcantara (load balance plz) wrote: > Holding off on reviewing this until ...
3 years, 10 months ago (2017-01-26 10:48:38 UTC) #9
Bernhard Bauer
On 2017/01/26 10:48:38, marcin wrote: > On 2017/01/17 18:37:29, dfalcantara (load balance plz) wrote: > ...
3 years, 10 months ago (2017-01-26 13:53:07 UTC) #10
marcin
On 2017/01/26 13:53:07, Bernhard Bauer wrote: > On 2017/01/26 10:48:38, marcin wrote: > > On ...
3 years, 10 months ago (2017-02-08 01:24:57 UTC) #11
marcin
3 years, 8 months ago (2017-03-25 19:43:30 UTC) #12
On 2017/02/08 01:24:57, marcin wrote:
> On 2017/01/26 13:53:07, Bernhard Bauer wrote:
> > On 2017/01/26 10:48:38, marcin wrote:
> > > On 2017/01/17 18:37:29, dfalcantara (load balance plz) wrote:
> > > > Holding off on reviewing this until you've discussed this and gotten
> > approval
> > > > from UX.  I've added the relevant people to your bug.
> > > 
> > > Thank you,
> > > 
> > > team can't decide since 12 Jan if changes are OK or not (if not, why). Is
it
> > > possible to speed it up?
> > 
> > Maybe ask on the bug? Also, the last update was two days ago, not Jan 12.
> 
> Hello everybody,
> 
> Could some of you maybe look on the bug and maybe take voice in the discussion
?
> I don't see any very strong voices against, but we're not moving forward.

due to lack of progress and changes in code done by other people splitted into
separate/other patches

Powered by Google App Engine
This is Rietveld 408576698