Adding attributes to module and struct in mojom.

Adding attributes to module and struct in mojom.

Struct already had attributes, but were discarding the result. Module attributes will be used by the java generator to set the java package.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268177

[qsr, 2014-04-30 13:03:45]

https://codereview.chromium.org/262633005/diff/1/mojo/public/tools/bindings/p...
File mojo/public/tools/bindings/pylib/mojom/parse/translate.py (right):

https://codereview.chromium.org/262633005/diff/1/mojo/public/tools/bindings/p...
mojo/public/tools/bindings/pylib/mojom/parse/translate.py:45: def
_AttributeValueToString(v):
Not sure this is the best solution. If you think it is better, I can re work on
the lexer to add an attribute_value token which would be mostly anything but
comma. We would need to decide what to do with whitespace though...

[qsr, 2014-05-02 07:21:13]

gentle ping?

[darin (slow to review), 2014-05-02 07:44:01]

LGTM

Can you please update the CL description with a sample of how you intend to use
module and struct attributes?

https://codereview.chromium.org/262633005/diff/1/mojo/public/tools/bindings/p...
File mojo/public/tools/bindings/pylib/mojom/parse/translate.py (right):

https://codereview.chromium.org/262633005/diff/1/mojo/public/tools/bindings/p...
mojo/public/tools/bindings/pylib/mojom/parse/translate.py:45: def
_AttributeValueToString(v):
On 2014/04/30 13:03:45, qsr wrote:
> Not sure this is the best solution. If you think it is better, I can re work
on
> the lexer to add an attribute_value token which would be mostly anything but
> comma. We would need to decide what to do with whitespace though...

Do you think that would help us catch syntactic errors earlier? If so, then we
should probably do it.

Also, I think it would be helpful to add a comment here describing the transform
MapAttributes is performing.

[qsr, 2014-05-05 12:40:05]

https://codereview.chromium.org/262633005/diff/1/mojo/public/tools/bindings/p...
File mojo/public/tools/bindings/pylib/mojom/parse/translate.py (right):

https://codereview.chromium.org/262633005/diff/1/mojo/public/tools/bindings/p...
mojo/public/tools/bindings/pylib/mojom/parse/translate.py:45: def
_AttributeValueToString(v):
On 2014/05/02 07:44:01, darin wrote:
> On 2014/04/30 13:03:45, qsr wrote:
> > Not sure this is the best solution. If you think it is better, I can re work
> on
> > the lexer to add an attribute_value token which would be mostly anything but
> > comma. We would need to decide what to do with whitespace though...
> 
> Do you think that would help us catch syntactic errors earlier? If so, then we
> should probably do it.

 Finally, I let the expression, and decided to use string literal if needed.
This solve the question we could have with whitespaces.

> Also, I think it would be helpful to add a comment here describing the
transform
> MapAttributes is performing.

 I removed this also. I just keep the full expression, and let any user do what
it needs with it. This is because we might really have expression there someday,
as done as an example in sample_service.mojom

[qsr, 2014-05-05 12:40:13]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-05-05 12:40:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/262633005/20001

[commit-bot: I haz the power, 2014-05-05 12:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-05 12:40:35]

Failed to apply patch for
mojo/public/interfaces/bindings/tests/sample_import2.mojom:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file mojo/public/interfaces/bindings/tests/sample_import2.mojom

Patch:       mojo/public/interfaces/bindings/tests/sample_import2.mojom
Index: mojo/public/interfaces/bindings/tests/sample_import2.mojom
diff --git a/mojo/public/interfaces/bindings/tests/sample_import2.mojom
b/mojo/public/interfaces/bindings/tests/sample_import2.mojom
index
e5fd72d7fe898bc6f027a185b877a04b079b5a68..f7f5c57a8040ebaee34a1d4f887a8d810b711855
100644
--- a/mojo/public/interfaces/bindings/tests/sample_import2.mojom
+++ b/mojo/public/interfaces/bindings/tests/sample_import2.mojom
@@ -4,10 +4,11 @@
 
 import "sample_import.mojom"
 
+[JavaPackage="org.chromium.mojo.bindings.test"]
 module imported {
 
 // This sample adds more types and constants to the "imported" namespace,
-// to test a bug with importing multiple modules with the same namespace.
+// to test a bug with importing multiple
[JavaPackage="org.chromium.mojo.bindings.test"]
modules with the same namespace.
 
 enum Color {
   COLOR_RED,
@@ -26,4 +27,4 @@ struct Thing {
   Size size;
 };
 
-}  // module imported
+}  // [JavaPackage="org.chromium.mojo.bindings.test"]
module imported

[qsr, 2014-05-05 12:49:45]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-05-05 12:49:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/262633005/40001

[commit-bot: I haz the power, 2014-05-05 14:17:31]

Change committed as 268177