Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: src/wasm/wasm-interpreter.cc

Issue 2626313003: [wasm] Change the constant kV8MaxWasmMemoryPages to a command line flag. (Closed)
Patch Set: typo Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-interpreter.cc
diff --git a/src/wasm/wasm-interpreter.cc b/src/wasm/wasm-interpreter.cc
index aa0884c50c2644c9f9d2d57e147eea0019cd6d2b..a0d687b64991606bf339dccf3c4a7ec15d922cb0 100644
--- a/src/wasm/wasm-interpreter.cc
+++ b/src/wasm/wasm-interpreter.cc
@@ -664,7 +664,7 @@ static inline int32_t ExecuteGrowMemory(uint32_t delta_pages,
WasmInstance* instance) {
// TODO(ahaas): Move memory allocation to wasm-module.cc for better
// encapsulation.
- if (delta_pages > wasm::kV8MaxWasmMemoryPages ||
+ if (delta_pages > static_cast<uint32_t>(FLAG_wasm_max_mem_pages) ||
delta_pages > instance->module->max_mem_pages) {
return -1;
}
@@ -681,7 +681,8 @@ static inline int32_t ExecuteGrowMemory(uint32_t delta_pages,
} else {
DCHECK_NOT_NULL(instance->mem_start);
new_size = old_size + delta_pages * wasm::WasmModule::kPageSize;
- if (new_size / wasm::WasmModule::kPageSize > wasm::kV8MaxWasmMemoryPages ||
+ if (new_size / wasm::WasmModule::kPageSize >
+ static_cast<uint32_t>(FLAG_wasm_max_mem_pages) ||
new_size / wasm::WasmModule::kPageSize >
instance->module->max_mem_pages) {
return -1;
« src/flag-definitions.h ('K') | « src/wasm/module-decoder.cc ('k') | src/wasm/wasm-limits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698