Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2626193003: Gardening: updating status file to skip http_server_close_response_after_error_test on vm-win-relea… (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
Reviewers:
zra, Cutch, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: updating status file to skip http_server_close_response_after_error_test on vm-win-release-x64-be due to flakiness. See issue #28370. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/b0d99a2620324cd0075ba5cb27d80c22bb6c9114

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switched from skip to Pass,Timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/standalone/standalone.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
bkonyi
3 years, 11 months ago (2017-01-12 20:46:27 UTC) #2
zra
- cutchccutchan, +johnmccutchan https://codereview.chromium.org/2626193003/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2626193003/diff/1/tests/standalone/standalone.status#newcode283 tests/standalone/standalone.status:283: io/http_server_close_response_after_error_test: Skip # Issue 28370: timeout. ...
3 years, 11 months ago (2017-01-12 20:52:00 UTC) #4
bkonyi
https://codereview.chromium.org/2626193003/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2626193003/diff/1/tests/standalone/standalone.status#newcode283 tests/standalone/standalone.status:283: io/http_server_close_response_after_error_test: Skip # Issue 28370: timeout. On 2017/01/12 at ...
3 years, 11 months ago (2017-01-12 20:54:59 UTC) #5
zra
lgtm
3 years, 11 months ago (2017-01-12 20:57:30 UTC) #6
bkonyi
3 years, 11 months ago (2017-01-12 20:59:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b0d99a2620324cd0075ba5cb27d80c22bb6c9114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698