Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2626193002: add Intel Code Analyst markers (Closed)

Created:
3 years, 11 months ago by fbarchard1
Modified:
3 years, 11 months ago
Reviewers:
wangcheng, janwas
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

add Intel Code Analyst markers add macros to enable/disable code analyst around blocks of code. Normally these macros should not be used, but if performance details are wanted for intel code, enable them around the code and then run via the iaca tool, available on the intel website. BUG=libyuv:670 TEST=~/iaca-lin64/bin/iaca.sh -64 out/Release/libyuv_unittest R=wangcheng@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/a7c87e19f010f109a03e99abfe664ba35d8b8e62

Patch Set 1 #

Patch Set 2 : add markers that can be used for inline #

Total comments: 3

Patch Set 3 : remove formatting changes #

Patch Set 4 : Add Intel Code Analyst markers #

Patch Set 5 : remove row_gcc example so try bots pass #

Patch Set 6 : rebase, clang-format, bump version, add comment about visual c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -19 lines) Patch
M README.chromium View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
M include/libyuv/version.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/convert_to_argb.cc View 1 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M source/row_gcc.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M unit_test/convert_test.cc View 1 3 4 5 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fbarchard1
Add macros for Intel Architecture Code Analyst that can be embedded into gcc style assembly.
3 years, 11 months ago (2017-01-13 02:12:08 UTC) #2
fbarchard1
https://codereview.chromium.org/2626193002/diff/20001/source/convert_to_argb.cc File source/convert_to_argb.cc (right): https://codereview.chromium.org/2626193002/diff/20001/source/convert_to_argb.cc#newcode261 source/convert_to_argb.cc:261: inv_crop_height, rotation); fyi ran clang-format on everything https://codereview.chromium.org/2626193002/diff/20001/source/row_gcc.cc File ...
3 years, 11 months ago (2017-01-13 02:14:43 UTC) #3
fbarchard1
make ifdefs check cpu, which implies gcc or clang. should work for clangcl as well.
3 years, 11 months ago (2017-01-13 18:34:34 UTC) #4
wangcheng
lgtm
3 years, 11 months ago (2017-01-13 23:28:03 UTC) #6
fbarchard1
3 years, 11 months ago (2017-01-13 23:50:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
a7c87e19f010f109a03e99abfe664ba35d8b8e62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698