extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc - Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)

Patch Set: Finish partial comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/renderer/guest_view_request.cc ('k') | extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc » ('j') | third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

index bec7d1c852016119b6a3df2e7c81ffbda0047867..70ba142fab03ea751fd9a42025b6501956391018 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

@@ -320,8 +320,7 @@ void GuestViewInternalCustomBindings::GetContentWindow(

if (frame->isWebLocalFrame()) {

window = frame->mainWorldScriptContext()->Global();

} else {

- window =

- frame->toWebRemoteFrame()->deprecatedMainWorldScriptContext()->Global();

+ window = frame->toWebRemoteFrame()->globalProxy();

}

args.GetReturnValue().Set(window);

}