extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc - Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('k') | third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

index bb13920fe72cc786d2cb1b39b8deb25fc22a6d30..811e3caa9d72ec6a7806aca8cdfa7e889f6c57e3 100644

--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

@@ -242,9 +242,7 @@ void MimeHandlerViewContainer::PostMessage(v8::Isolate* isolate,

guest_proxy_window =

guest_proxy_frame->mainWorldScriptContext()->Global();

} else {

- guest_proxy_window = guest_proxy_frame->toWebRemoteFrame()

- ->deprecatedMainWorldScriptContext()

- ->Global();

+ guest_proxy_window = guest_proxy_frame->toWebRemoteFrame()->globalProxy();

}

gin::Dictionary window_object(isolate, guest_proxy_window);

v8::Local<v8::Function> post_message;