Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/public/web/WebRemoteFrame.h

Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebRemoteFrame.h
diff --git a/third_party/WebKit/public/web/WebRemoteFrame.h b/third_party/WebKit/public/web/WebRemoteFrame.h
index 9f3b4e5254cd958aa857a2edd06f25c46aa0907a..c051d482ecfd6da4988775995a28f57b3443f911 100644
--- a/third_party/WebKit/public/web/WebRemoteFrame.h
+++ b/third_party/WebKit/public/web/WebRemoteFrame.h
@@ -11,6 +11,10 @@
#include "public/web/WebFrame.h"
#include "public/web/WebSandboxFlags.h"
+namespace v8 {
+class Object;
haraken 2017/02/14 11:15:01 We normally just include v8.h.
dcheng 2017/02/15 11:08:41 Done.
+};
+
namespace blink {
enum class WebTreeScopeType;
@@ -104,7 +108,7 @@ class WebRemoteFrame : public WebFrame {
// Temporary method to allow embedders to get the script context of a
// remote frame. This should only be used by legacy code that has not yet
// migrated over to the new OOPI infrastructure.
- virtual v8::Local<v8::Context> deprecatedMainWorldScriptContext() const = 0;
+ virtual v8::Local<v8::Object> globalProxy() const = 0;
protected:
explicit WebRemoteFrame(WebTreeScopeType scope) : WebFrame(scope) {}

Powered by Google App Engine
This is Rietveld 408576698