Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 26261009: Add toSVGColor|Paint() to cleanup static_cast<>, and use it (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, haraken, Inactive
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, pdr, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, f(malita), Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add toSVGColor|Paint() to cleanup static_cast<>, and use it SVGColor and SVGPaint can't use DEFINE_CSS_VALUE_TYPE_CASTS(), this cl adds toSVGColor() and toSVGPaint() manually. Those functions will help to detect bad type cast. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159425

Patch Set 1 #

Patch Set 2 : Cover static_cast<const SVGPaint|Color*> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M Source/bindings/v8/custom/V8CSSValueCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGColor.h View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPaint.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-10 11:21:29 UTC) #1
Stephen Chennney
On 2013/10/10 11:21:29, gyuyoung wrote: > Add tkent. Run this through the trybots please. And ...
7 years, 2 months ago (2013-10-10 15:21:19 UTC) #2
tkent
lgtm for !Source/bindings/
7 years, 2 months ago (2013-10-10 21:00:07 UTC) #3
haraken
On 2013/10/10 21:00:07, tkent wrote: > lgtm for !Source/bindings/ LGTM for bindings/
7 years, 2 months ago (2013-10-10 23:42:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26261009/1
7 years, 2 months ago (2013-10-10 23:46:08 UTC) #5
gyuyoung-inactive
On 2013/10/10 21:00:07, tkent wrote: > lgtm for !Source/bindings/ Sorry, I missed to cleanup static_cast<const ...
7 years, 2 months ago (2013-10-11 00:41:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26261009/14001
7 years, 2 months ago (2013-10-11 01:05:41 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 05:29:59 UTC) #8
Message was sent while issue was closed.
Change committed as 159425

Powered by Google App Engine
This is Rietveld 408576698