Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1999)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

Issue 2626083004: Signin: Reuse existing "update gms" dialogs when possible. (Closed)
Patch Set: "Error code" -> "Last error code" Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
index 792a0ca8e7d8e069799aa6a73d3f354b9dad2f13..bfa92a1114fbd2edb2974fb727234779a114c57a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
@@ -336,9 +336,11 @@ public class AccountSigninView extends FrameLayout implements ProfileDownloader.
private boolean checkGooglePlayServicesAvailable() {
ExternalAuthUtils extAuthUtils = ExternalAuthUtils.getInstance();
- boolean cancelable = !SigninManager.get(getContext()).isForceSigninEnabled();
- mGooglePlayServicesUpdateErrorHandler = new UserRecoverableErrorHandler.ModalDialog(
- mDelegate.getActivity(), cancelable);
+ if (mGooglePlayServicesUpdateErrorHandler == null) {
+ boolean cancelable = !SigninManager.get(getContext()).isForceSigninEnabled();
+ mGooglePlayServicesUpdateErrorHandler = new UserRecoverableErrorHandler.ModalDialog(
+ mDelegate.getActivity(), cancelable);
+ }
int resultCode = extAuthUtils.canUseGooglePlayServicesResultCode(
getContext(), mGooglePlayServicesUpdateErrorHandler);
if (extAuthUtils.isGooglePlayServicesUpdateRequiredError(resultCode)) {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698