Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 2626073007: Make drag-and-drop work with OOPIF-WebView. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
index 7a43d338446f3cb07ba5b96cd6e693b5727d4d97..0cf066b708be6b70d484dd310f680df23797546c 100644
--- a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
@@ -513,6 +513,7 @@ class WebViewInteractiveTest : public WebViewInteractiveTestBase,
}
};
+class WebViewDragDropInteractiveTest : public WebViewInteractiveTest {};
class WebViewNewWindowInteractiveTest : public WebViewInteractiveTest {};
class WebViewPointerLockInteractiveTest : public WebViewInteractiveTest {};
@@ -524,13 +525,16 @@ class WebViewContextMenuInteractiveTest : public WebViewInteractiveTestBase {};
// with WebViewInteractiveTest (see crbug.com/582562).
class WebViewFocusInteractiveTest : public WebViewInteractiveTestBase {};
class WebViewPopupInteractiveTest : public WebViewInteractiveTestBase {};
-class WebViewDragDropInteractiveTest : public WebViewInteractiveTestBase {};
INSTANTIATE_TEST_CASE_P(WebViewInteractiveTests,
WebViewInteractiveTest,
testing::Bool());
INSTANTIATE_TEST_CASE_P(WebViewInteractiveTests,
+ WebViewDragDropInteractiveTest,
+ testing::Bool());
+
+INSTANTIATE_TEST_CASE_P(WebViewInteractiveTests,
WebViewNewWindowInteractiveTest,
testing::Bool());
@@ -1037,7 +1041,7 @@ IN_PROC_BROWSER_TEST_F(WebViewPopupInteractiveTest,
// but the tests don't work on anything except chromeos for now. This is because
// of simulating mouse drag code's dependency on platforms.
#if defined(OS_CHROMEOS) && !defined(USE_OZONE)
-IN_PROC_BROWSER_TEST_F(WebViewDragDropInteractiveTest, DragDropWithinWebView) {
+IN_PROC_BROWSER_TEST_P(WebViewDragDropInteractiveTest, DragDropWithinWebView) {
LoadAndLaunchPlatformApp("web_view/dnd_within_webview", "connected");
ASSERT_TRUE(ui_test_utils::ShowAndFocusNativeWindow(GetPlatformAppWindow()));

Powered by Google App Engine
This is Rietveld 408576698