ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h - Issue 2626073003: [ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h

Issue 2626073003: [ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC. (Closed)

Patch Set: Some fixes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/contextual_search/contextual_search_metrics.mm ('k') | ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm » ('j') | ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h

diff --git a/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h b/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h

index 5299df07a38f4394951d9c1511aea5151f0b25d8..88a5a702d1f70d14b015503f2a1fdfc8bd9f6dfe 100644

--- a/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h

+++ b/ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h

@@ -21,7 +21,7 @@

@property(nonatomic, assign) ContextualSearch::PanelState state;

// Panel configuration, for motion observers that want to do different

// computations around panel state and position.

-@property(nonatomic, readonly) PanelConfiguration* configuration;

+@property(weak, nonatomic, readonly) PanelConfiguration* configuration;

marq (ping after 24h) 2017/01/13 10:38:17 Style nit: the atomicity attribute should come fir

stkhapugin 2017/01/17 15:57:44 Done.

// Create a panel view. It will need to have a delegate and controller assigned

// to do anything useful.