build/toolchain/toolchain.gni - Issue 2626063002: Allow using the same checkout to build both iOS and macOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/toolchain.gni

Issue 2626063002: Allow using the same checkout to build both iOS and macOS. (Closed)

Patch Set: Address nitpick. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/toolchain.gni

diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni

index baa4387d151cd523719fa945e0e09f167f633a61..563e8e89f8fcba1c9132773391b162f42fe9ae3e 100644

--- a/build/toolchain/toolchain.gni

+++ b/build/toolchain/toolchain.gni

@@ -46,7 +46,7 @@ declare_args() {

# The path to the hermetic install of Xcode. Only relevant when

# use_system_xcode = false.

hermetic_xcode_path =

- rebase_path("//build/mac_files/Xcode.app", "", root_build_dir)

+ rebase_path("//build/${target_os}_files/Xcode.app", "", root_build_dir)

declare_args() {

if (is_clang) {

« no previous file with comments | « build/mac_toolchain.py ('k') | no next file » | no next file with comments »