Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2626043006: Fuchsia: Disable service origin check. Bind service to all interfaces. (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Disable service origin check. Bind service to all interfaces. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/6f9dcaff9de577f5426c422c8b39f17c7eb9bb30

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M runtime/bin/vmservice/server.dart View 2 chunks +10 lines, -6 lines 2 comments Download
M sdk/lib/io/platform.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 11 months ago (2017-01-13 18:22:44 UTC) #2
siva
lgtm https://codereview.chromium.org/2626043006/diff/1/runtime/bin/vmservice/server.dart File runtime/bin/vmservice/server.dart (right): https://codereview.chromium.org/2626043006/diff/1/runtime/bin/vmservice/server.dart#newcode311 runtime/bin/vmservice/server.dart:311: address = InternetAddress.ANY_IP_V6; Will this also work for ...
3 years, 11 months ago (2017-01-13 18:33:00 UTC) #3
zra
https://codereview.chromium.org/2626043006/diff/1/runtime/bin/vmservice/server.dart File runtime/bin/vmservice/server.dart (right): https://codereview.chromium.org/2626043006/diff/1/runtime/bin/vmservice/server.dart#newcode311 runtime/bin/vmservice/server.dart:311: address = InternetAddress.ANY_IP_V6; On 2017/01/13 18:33:00, siva wrote: > ...
3 years, 11 months ago (2017-01-13 20:25:57 UTC) #4
zra
3 years, 11 months ago (2017-01-13 20:27:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6f9dcaff9de577f5426c422c8b39f17c7eb9bb30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698