Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2626043002: Do not refer to initializing parameters in initializer lists. (Closed)

Created:
3 years, 11 months ago by asgerf
Modified:
3 years, 11 months ago
Reviewers:
Leaf, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not refer to initializing parameters in initializer lists. This feature is not supported by the fixed VM version in tools/sdks which our tests rely on. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/8aad3affc2f43f8ec5e44f05e9cc5b55fea2f87e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
asgerf
Hopefully we will get an updated SDK soon, but this is really blocking me right ...
3 years, 11 months ago (2017-01-12 15:37:09 UTC) #7
Bill Hesse
LGTM. Sorry I haven't updated the SDK yet - it's on my list.
3 years, 11 months ago (2017-01-12 15:38:56 UTC) #8
asgerf
3 years, 11 months ago (2017-01-12 16:20:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8aad3affc2f43f8ec5e44f05e9cc5b55fea2f87e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698