Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tests/corelib/uri_test.dart

Issue 2626013004: Fix invalid URIs generated using Uri constructor with clever paths. (Closed)
Patch Set: Fix typo, name boolean parameter (address comments). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/uri_test.dart
diff --git a/tests/corelib/uri_test.dart b/tests/corelib/uri_test.dart
index d4ca36dd9afe8920ef9752c48f57483561068733..bcd097695f582943aeca0030b927f740d1fd8971 100644
--- a/tests/corelib/uri_test.dart
+++ b/tests/corelib/uri_test.dart
@@ -765,7 +765,7 @@ void testRegression28359() {
Expect.isTrue(uri.hasAuthority, "$uri has authority");
uri = new Uri(path: "file:///wat");
- // This is an invalid pat for a URI reference with no authority or scheme
+ // This is an invalid path for a URI reference with no authority or scheme
// since the path looks like it starts with a scheme.
// Normalized by escaping the ":".
Expect.equals("file%3A///wat", uri.path);
@@ -835,7 +835,7 @@ main() {
Expect.throws(
() => Uri.parse("http:").origin,
(e) { return e is StateError; },
- "origin for uri with empty host should fail");
+ "origin for URI with empty host should fail");
Expect.throws(
() => new Uri(
scheme: "http",
@@ -846,7 +846,7 @@ main() {
query: "query",
fragment: "fragment").origin,
(e) { return e is StateError; },
- "origin for uri with empty host should fail");
+ "origin for URI with empty host should fail");
Expect.throws(
() => new Uri(
scheme: null,
@@ -857,7 +857,7 @@ main() {
query: "query",
fragment: "fragment").origin,
(e) { return e is StateError; },
- "origin for uri with empty scheme should fail");
+ "origin for URI with empty scheme should fail");
Expect.throws(
() => new Uri(
scheme: "http",
@@ -868,11 +868,11 @@ main() {
query: "query",
fragment: "fragment").origin,
(e) { return e is StateError; },
- "origin for uri with empty host should fail");
+ "origin for URI with empty host should fail");
Expect.throws(
() => Uri.parse("http://:80").origin,
(e) { return e is StateError; },
- "origin for uri with empty host should fail");
+ "origin for URI with empty host should fail");
Expect.throws(
() => Uri.parse("file://localhost/test.txt").origin,
(e) { return e is StateError; },
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698