Issue 2626006: Update action_lid.sh to use new RequestSuspend signal (6 of 7).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2626006: Update action_lid.sh to use new RequestSuspend signal (6 of 7). (Closed)

Created:
10 years, 6 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Sameer Nanda

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/acpi.git

Visibility:
Public.

Description

Update action_lid.sh to use new RequestSuspend signal (6 of 7). Depends on the following change: - Issue 2701001: Update power manager to support suspend (5 of 7). BUG=chromium-os:3694 TEST=Emerged to device and tested it with the new power manager change.

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -48 lines)			Patch
	M	action_lid.sh	View		1 chunk	+2 lines, -48 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sameer Nanda

10 years, 6 months ago (2010-06-07 02:38:34 UTC) #2

LGTM modulo comment

http://codereview.chromium.org/2626006/diff/1/2
File action_lid.sh (right):

http://codereview.chromium.org/2626006/diff/1/2#newcode15
action_lid.sh:15: logger "action_lid.sh: lid closed. Requesting suspend."
use '-t' to add a tag and preferably use the same tag for all power management
entities to help with grepping.

Expand Messages | Collapse Messages