Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2625933006: MIPS[64]: Fix `Internalize strings in-place (reland)` (Closed)

Created:
3 years, 11 months ago by ivica.bogosavljevic
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Fix `Internalize strings in-place (reland)` Fix 4c699e349a4986b28574b3a51e8780e3a3d067b1 Around 400 tests fail do to the typo in the MIPS port. TEST=mjsunit/regexp-capture-3,mjsunit/string-slices-regexp,... BUG=

Patch Set 1 #

Patch Set 2 : Fix typo in a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/code-stubs-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (6 generated)
Jakob Kummerow
I just had to revert that CL again. I'll include this fix in the reland.
3 years, 11 months ago (2017-01-12 15:30:17 UTC) #5
ivica.bogosavljevic
3 years, 11 months ago (2017-01-12 15:36:45 UTC) #6
On 2017/01/12 15:30:17, Jakob Kummerow wrote:
> I just had to revert that CL again. I'll include this fix in the reland.

Ok. In that case I am not committing this

Powered by Google App Engine
This is Rietveld 408576698