Issue 262593003: Revert of Ignoring minimum size requirements for maximized windows, full screen windows and too small screens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262593003: Revert of Ignoring minimum size requirements for maximized windows, full screen windows and too small screens (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 7 months ago

Reviewers:
Ben Goodger (Google), Mr4D (OOO till 08-26)

CC:
chromium-reviews, kalyank, ben+aura_chromium.org, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Ignoring minimum size requirements for maximized windows, full screen windows and too small screens (https://codereview.chromium.org/255063004/) Reason for revert: [Sheriff] Breaks NormalOrPanel/DockedWindowLayoutManagerTest.WidthMoreThanMax/1 on CrOS: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/42711 Original issue's description: > Ignoring minimum size requirements for maximized windows, full screen windows and too small screens > > BUG=366315 > TEST=ash_unittest's and visual tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267084 TBR=ben@chromium.org,skuhne@chromium.org NOTREECHECKS=true NOTRY=true BUG=366315 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267101

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -88 lines)			Patch
M	ash/wm/window_state.cc	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	ash/wm/window_state_unittest.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	ui/aura/window.cc	View	2 chunks	+12 lines, -11 lines	0 comments	Download

Total messages: 1 (0 generated)

Michael Achenbach

6 years, 7 months ago (2014-04-30 06:45:23 UTC) #1

Created Revert of Ignoring minimum size requirements for maximized windows, full
screen windows and too small screens