chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java - Issue 2625923002: Introduce the bottom sheet class for Chrome Home

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

Issue 2625923002: Introduce the bottom sheet class for Chrome Home (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

index 84a77aad5d304c0f1fb4d3f9512ec6115bdbf16b..1942755d0ebc934fce6768338dd70a1082544bda 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

@@ -113,6 +113,7 @@ public class ToolbarControlContainer extends FrameLayout implements ControlConta

ViewUtils.gatherTransparentRegionsForOpaqueView(this, region);

setTranslationY(translateY);

+ region.setEmpty();

Ian Wen 2017/01/11 19:46:53 Q: what's this for?

mdjones 2017/01/12 21:26:57 I moved this over to BottomSheet.java. I have it s

return true;

}