third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp - Issue 2625873010: Resolve CSS url(...) non-<image> values against the correct base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2625873010: Resolve CSS url(...) non-<image> values against the correct base (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

index 20e37e65827ad6ff0ef1e92f28b456e38a8ff695..4b438c255c3c38532d465dcd251db3d9ab353d5b 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

@@ -376,11 +376,13 @@ StringView consumeUrlAsStringView(CSSParserTokenRange& range) {

return StringView();

}

-CSSURIValue* consumeUrl(CSSParserTokenRange& range) {

+CSSURIValue* consumeUrl(CSSParserTokenRange& range,

+ const CSSParserContext* context) {

StringView url = consumeUrlAsStringView(range);

if (url.isNull())

return nullptr;

- return CSSURIValue::create(url.toString());

+ String urlString = url.toString();

+ return CSSURIValue::create(urlString, context->completeURL(urlString));

}

static int clampRGBComponent(const CSSPrimitiveValue& value) {