[ast] Remove heap accesses from AST numbering

src/interpreter/bytecode-array-builder.h

Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index c2568eb8e6612d18acf9cdc1ecbc8c01c1f5f89d..803d9dd218c5dfde6e9982e4edb2fbc84e85b835 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -190,12 +190,10 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final
   // Literals creation.  Constant elements should be in the accumulator.
   BytecodeArrayBuilder& CreateRegExpLiteral(Handle<String> pattern,
                                             int literal_index, int flags);
-  BytecodeArrayBuilder& CreateArrayLiteral(
-      Handle<ConstantElementsPair> constant_elements, int literal_index,
-      int flags);
-  BytecodeArrayBuilder& CreateObjectLiteral(
-      Handle<FixedArray> constant_properties, int literal_index, int flags,
-      Register output);
+  BytecodeArrayBuilder& CreateArrayLiteral(size_t entry, int literal_index,

[rmcilroy, 2017/01/13 09:53:57]

nit - constant_elements_entry (and in cc file)

[Leszek Swirski, 2017/01/13 10:58:10]

Done. (Also changed CreateClosure for consistency)

+                                           int flags);
+  BytecodeArrayBuilder& CreateObjectLiteral(size_t entry, int literal_index,

[rmcilroy, 2017/01/13 09:53:57]

nit - constant_properties_entry (and in cc file)

[Leszek Swirski, 2017/01/13 10:58:10]

Done.

+                                            int flags, Register output);
 
   // Push the context in accumulator as the new context, and store in register
   // |context|.
@@ -328,6 +326,8 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final
   // entry, so that it can be referenced by above exception handling support.
   int NewHandlerEntry() { return handler_table_builder()->NewHandlerEntry(); }
 
+  // Gets a constant pool entry for the |object|.
+  size_t GetConstantPoolEntry(Handle<Object> object);
   // Allocates a slot in the constant pool which can later be inserted.
   size_t AllocateConstantPoolEntry();
   // Inserts a entry into an allocated constant pool entry.
@@ -394,9 +394,6 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final
   // Set position for return.
   void SetReturnPosition();
 
-  // Gets a constant pool entry for the |object|.
-  size_t GetConstantPoolEntry(Handle<Object> object);
-
   // Not implemented as the illegal bytecode is used inside internally
   // to indicate a bytecode field is not valid or an error has occured
   // during bytecode generation.