Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: src/ast/ast-numbering.h

Issue 2625873009: [ast] Remove heap accesses from AST numbering (Closed)
Patch Set: Fix GCMole failure Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/ast-numbering.h
diff --git a/src/ast/ast-numbering.h b/src/ast/ast-numbering.h
index e6a06901c6a6ebaa0beacabaec7f229c2527bd51..669e36a416a5ed1ce7a266220ffc22b6ede9158b 100644
--- a/src/ast/ast-numbering.h
+++ b/src/ast/ast-numbering.h
@@ -5,11 +5,15 @@
#ifndef V8_AST_AST_NUMBERING_H_
#define V8_AST_AST_NUMBERING_H_
+#include <stdint.h>
rmcilroy 2017/01/13 09:53:57 Unecessary?
Leszek Swirski 2017/01/13 10:58:10 Necessary, for uintptr_t
+
namespace v8 {
namespace internal {
// Forward declarations.
class FunctionLiteral;
+class ObjectLiteral;
+class ArrayLiteral;
rmcilroy 2017/01/13 09:53:57 Ditto?
Leszek Swirski 2017/01/13 10:58:10 Removed.
class Isolate;
class Zone;
template <typename T>
@@ -22,9 +26,10 @@ class ZoneVector;
namespace AstNumbering {
// Assign type feedback IDs, bailout IDs, and generator yield IDs to an AST node
// tree; perform catch prediction for TryStatements. If |eager_literals| is
-// non-null, adds any eager inner literal functions into it.
+// non-null, adds any eager inner literal functions into it. Adds ObjectLiterals
+// to |object_literals| and ArrayLiterals to |array_literals|.
rmcilroy 2017/01/13 09:53:57 Remove sentence added here?
Leszek Swirski 2017/01/13 10:58:10 Oops, leftovers. Removed.
bool Renumber(
- Isolate* isolate, Zone* zone, FunctionLiteral* function,
+ uintptr_t stack_limit, Zone* zone, FunctionLiteral* function,
ThreadedList<ThreadedListZoneEntry<FunctionLiteral*>>* eager_literals);
}

Powered by Google App Engine
This is Rietveld 408576698