Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2625873009: [ast] Remove heap accesses from AST numbering (Closed)
Patch Set: Address nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
index 30abb96fbd9af3abafa467a72f301a91cc8f9286..e9b996ea099fb9e533810dbad55fce937d526c38 100644
--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc
+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
@@ -126,11 +126,9 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
builder.CreateWithContext(reg, factory->NewScopeInfo(1));
// Emit literal creation operations.
- builder.CreateRegExpLiteral(factory->NewStringFromStaticChars("a"), 0, 0)
- .CreateArrayLiteral(factory->NewConstantElementsPair(
- FAST_ELEMENTS, factory->empty_fixed_array()),
- 0, 0)
- .CreateObjectLiteral(factory->NewFixedArray(1), 0, 0, reg);
+ builder.CreateRegExpLiteral(factory->NewStringFromStaticChars("a"), 0, 0);
+ builder.CreateArrayLiteral(0, 0, 0);
+ builder.CreateObjectLiteral(0, 0, 0, reg);
// Call operations.
builder.Call(reg, reg_list, 1, Call::GLOBAL_CALL)
@@ -344,10 +342,8 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
builder
.CreateRegExpLiteral(factory->NewStringFromStaticChars("wide_literal"), 0,
0)
- .CreateArrayLiteral(factory->NewConstantElementsPair(
- FAST_ELEMENTS, factory->empty_fixed_array()),
- 0, 0)
- .CreateObjectLiteral(factory->NewFixedArray(2), 0, 0, reg);
+ .CreateArrayLiteral(0, 0, 0)
+ .CreateObjectLiteral(0, 0, 0, reg);
// Emit load and store operations for module variables.
builder.LoadModuleVariable(-1, 42)
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698