Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: src/ast/ast-numbering.h

Issue 2625873009: [ast] Remove heap accesses from AST numbering (Closed)
Patch Set: Address nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_AST_NUMBERING_H_ 5 #ifndef V8_AST_AST_NUMBERING_H_
6 #define V8_AST_AST_NUMBERING_H_ 6 #define V8_AST_AST_NUMBERING_H_
7 7
8 #include <stdint.h>
9
8 namespace v8 { 10 namespace v8 {
9 namespace internal { 11 namespace internal {
10 12
11 // Forward declarations. 13 // Forward declarations.
12 class FunctionLiteral; 14 class FunctionLiteral;
13 class Isolate; 15 class Isolate;
14 class Zone; 16 class Zone;
15 template <typename T> 17 template <typename T>
16 class ThreadedList; 18 class ThreadedList;
17 template <typename T> 19 template <typename T>
18 class ThreadedListZoneEntry; 20 class ThreadedListZoneEntry;
19 template <typename T> 21 template <typename T>
20 class ZoneVector; 22 class ZoneVector;
21 23
22 namespace AstNumbering { 24 namespace AstNumbering {
23 // Assign type feedback IDs, bailout IDs, and generator yield IDs to an AST node 25 // Assign type feedback IDs, bailout IDs, and generator yield IDs to an AST node
24 // tree; perform catch prediction for TryStatements. If |eager_literals| is 26 // tree; perform catch prediction for TryStatements. If |eager_literals| is
25 // non-null, adds any eager inner literal functions into it. 27 // non-null, adds any eager inner literal functions into it.
26 bool Renumber( 28 bool Renumber(
27 Isolate* isolate, Zone* zone, FunctionLiteral* function, 29 uintptr_t stack_limit, Zone* zone, FunctionLiteral* function,
28 ThreadedList<ThreadedListZoneEntry<FunctionLiteral*>>* eager_literals); 30 ThreadedList<ThreadedListZoneEntry<FunctionLiteral*>>* eager_literals);
29 } 31 }
30 32
31 // Some details on yield IDs 33 // Some details on yield IDs
32 // ------------------------- 34 // -------------------------
33 // 35 //
34 // In order to assist Ignition in generating bytecode for a generator function, 36 // In order to assist Ignition in generating bytecode for a generator function,
35 // we assign a unique number (the yield ID) to each Yield node in its AST. We 37 // we assign a unique number (the yield ID) to each Yield node in its AST. We
36 // also annotate loops with the number of yields they contain (loop.yield_count) 38 // also annotate loops with the number of yields they contain (loop.yield_count)
37 // and the smallest ID of those (loop.first_yield_id), and we annotate the 39 // and the smallest ID of those (loop.first_yield_id), and we annotate the
38 // function itself with the number of yields it contains (function.yield_count). 40 // function itself with the number of yields it contains (function.yield_count).
39 // 41 //
40 // The way in which we choose the IDs is simply by enumerating the Yield nodes. 42 // The way in which we choose the IDs is simply by enumerating the Yield nodes.
41 // Ignition relies on the following properties: 43 // Ignition relies on the following properties:
42 // - For each loop l and each yield y of l: 44 // - For each loop l and each yield y of l:
43 // l.first_yield_id <= y.yield_id < l.first_yield_id + l.yield_count 45 // l.first_yield_id <= y.yield_id < l.first_yield_id + l.yield_count
44 // - For the generator function f itself and each yield y of f: 46 // - For the generator function f itself and each yield y of f:
45 // 0 <= y.yield_id < f.yield_count 47 // 0 <= y.yield_id < f.yield_count
46 48
47 } // namespace internal 49 } // namespace internal
48 } // namespace v8 50 } // namespace v8
49 51
50 #endif // V8_AST_AST_NUMBERING_H_ 52 #endif // V8_AST_AST_NUMBERING_H_
OLDNEW
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698