Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js

Issue 2625873003: DevTools: Move history handling into FilteredListWidget from the delegate (Closed)
Patch Set: Fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 17 matching lines...) Expand all
28 28
29 /** 29 /**
30 * @unrestricted 30 * @unrestricted
31 */ 31 */
32 Sources.StyleSheetOutlineDialog = class extends QuickOpen.FilteredListWidget.Del egate { 32 Sources.StyleSheetOutlineDialog = class extends QuickOpen.FilteredListWidget.Del egate {
33 /** 33 /**
34 * @param {!Workspace.UISourceCode} uiSourceCode 34 * @param {!Workspace.UISourceCode} uiSourceCode
35 * @param {function(number, number)} selectItemCallback 35 * @param {function(number, number)} selectItemCallback
36 */ 36 */
37 constructor(uiSourceCode, selectItemCallback) { 37 constructor(uiSourceCode, selectItemCallback) {
38 super([]); 38 super();
39 this._selectItemCallback = selectItemCallback; 39 this._selectItemCallback = selectItemCallback;
40 /** @type {!Array<!Common.FormatterWorkerPool.CSSRule>} */ 40 /** @type {!Array<!Common.FormatterWorkerPool.CSSRule>} */
41 this._rules = []; 41 this._rules = [];
42 Common.formatterWorkerPool.parseCSS(uiSourceCode.workingCopy(), (isLastChunk , rules) => { 42 Common.formatterWorkerPool.parseCSS(uiSourceCode.workingCopy(), (isLastChunk , rules) => {
43 this._rules.push(...rules); 43 this._rules.push(...rules);
44 this.refresh(); 44 this.refresh();
45 }); 45 });
46 } 46 }
47 47
48 /** 48 /**
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 */ 105 */
106 selectItem(itemIndex, promptValue) { 106 selectItem(itemIndex, promptValue) {
107 if (itemIndex === null) 107 if (itemIndex === null)
108 return; 108 return;
109 var rule = this._rules[itemIndex]; 109 var rule = this._rules[itemIndex];
110 var lineNumber = rule.lineNumber; 110 var lineNumber = rule.lineNumber;
111 if (!isNaN(lineNumber) && lineNumber >= 0) 111 if (!isNaN(lineNumber) && lineNumber >= 0)
112 this._selectItemCallback(lineNumber, rule.columnNumber); 112 this._selectItemCallback(lineNumber, rule.columnNumber);
113 } 113 }
114 }; 114 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698