arc: Closing LSO page shoud disable ARC.

chrome/browser/chromeos/arc/arc_session_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
 
 #include <utility>
 
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/wm_shell.h"
@@ skipping 706 matching lines @@
 void ArcSessionManager::CancelAuthCode() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   if (state_ == State::NOT_INITIALIZED) {
     NOTREACHED();
     return;
   }
 
   // In case |state_| is ACTIVE, UI page can be ARC_LOADING (which means normal
   // ARC booting) or ERROR (in case ARC can not be started). If ARC is booting
-  // normally don't stop it on progress close.
+  // normally don't stop it on progress close. If current page is LSO then
+  // closing UI means no auth code and sign-in failure. Stop ARC in that case

[Luis Héctor Chávez, 2017/01/11 00:23:52]

nit: I'd probably reword it as

"If ARC failed to boot normally, stop ARC. Similarly, if the current page is
LSO, closing the window should stop ARC since the user actively chose to not
sign in. In any other case, ARC is booting normally and the instance should not
be stopped."

[khmel, 2017/01/11 05:36:43]

That is nice, thanks!

+  // too.
   if ((state_ != State::SHOWING_TERMS_OF_SERVICE &&
        state_ != State::CHECKING_ANDROID_MANAGEMENT) &&
       (!support_host_ ||
-       support_host_->ui_page() != ArcSupportHost::UIPage::ERROR)) {
+       (support_host_->ui_page() != ArcSupportHost::UIPage::ERROR &&
+        support_host_->ui_page() != ArcSupportHost::UIPage::LSO))) {
     return;
   }
 
   // Update UMA with user cancel only if error is not currently shown.
   if (support_host_ &&
       support_host_->ui_page() != ArcSupportHost::UIPage::NO_PAGE &&
       support_host_->ui_page() != ArcSupportHost::UIPage::ERROR) {
     UpdateOptInCancelUMA(OptInCancelReason::USER_CANCEL);
   }
 
@@ skipping 244 matching lines @@
       return os << "ACTIVE";
   }
 
   // Some compiler reports an error even if all values of an enum-class are
   // covered indivisually in a switch statement.
   NOTREACHED();
   return os;
 }
 
 }  // namespace arc