Password manager internals page service: introduction

components/password_manager/core/browser/log_router_unittest.cc

Index: components/password_manager/core/browser/log_router_unittest.cc
diff --git a/components/password_manager/core/browser/log_router_unittest.cc b/components/password_manager/core/browser/log_router_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fc86a3132f0b14d7431c2562aceee65a23675ff8
--- /dev/null
+++ b/components/password_manager/core/browser/log_router_unittest.cc
@@ -0,0 +1,92 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/password_manager/core/browser/log_router.h"
+
+#include "components/password_manager/core/browser/password_manager_logger.h"
+#include "components/password_manager/core/browser/stub_password_manager_client.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+
+namespace password_manager {
+
+namespace {
+
+const char kTestText[] = "abcd1234";
+
+class MockLogReceiver : public PasswordManagerLogger {
+ public:
+  MockLogReceiver() {}
+
+  MOCK_METHOD1(LogSavePasswordProgress, void(const std::string&));
+};
+
+}  // namespace
+
+class LogRouterTest : public testing::Test {
+ protected:
+  testing::StrictMock<MockLogReceiver> receiver_;
+  testing::StrictMock<MockLogReceiver> receiver2_;
+};
+
+TEST_F(LogRouterTest, ProcessLog_NoReceiver) {
+  LogRouter router;
+  // Without receivers, logs should not have been accumulated. That means that
+  // on the registration of the first receiver, none are returned.

[Ilya Sherman, 2014/05/07 00:28:39]

Did you mean to have a ProcessLog() call somewhere in this test?  Otherwise, the
accumulated logs are empty because nobody has tried to log anything, as well as
because there were no receivers.

[vabr (Chromium), 2014/05/07 13:42:59]

Good point. Since I cannot actually call ProcessLog without receivers, the only
thing to test here is that after receivers are registered and unregistered, all
accumulated logs are flushed. In this sense the test actually subsumes the
following one, though. I don't think I can avoid that.

+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver_));
+  router.UnregisterReceiver(&receiver_);
+}
+
+TEST_F(LogRouterTest, ProcessLog_OneReceiver) {
+  LogRouter router;
+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver_));
+  // Check that logs generated after activation are passed.
+  EXPECT_CALL(receiver_, LogSavePasswordProgress(kTestText)).Times(1);
+  router.ProcessLog(kTestText);
+  router.UnregisterReceiver(&receiver_);
+}
+
+TEST_F(LogRouterTest, ProcessLog_TwoReceiversAccumulatedLogsPassed) {
+  LogRouter router;
+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver_));
+
+  // Log something with only the first receiver, to accumulate some logs.
+  EXPECT_CALL(receiver_, LogSavePasswordProgress(kTestText)).Times(1);
+  EXPECT_CALL(receiver2_, LogSavePasswordProgress(kTestText)).Times(0);
+  router.ProcessLog(kTestText);
+  // Accumulated logs get passed on registration.
+  EXPECT_EQ(kTestText, router.RegisterReceiver(&receiver2_));
+  router.UnregisterReceiver(&receiver_);
+  router.UnregisterReceiver(&receiver2_);
+}
+
+TEST_F(LogRouterTest, ProcessLog_TwoReceiversBothUpdated) {
+  LogRouter router;
+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver_));
+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver2_));
+
+  // Check that both receivers get log updates.
+  EXPECT_CALL(receiver_, LogSavePasswordProgress(kTestText)).Times(1);
+  EXPECT_CALL(receiver2_, LogSavePasswordProgress(kTestText)).Times(1);
+  router.ProcessLog(kTestText);
+  router.UnregisterReceiver(&receiver2_);
+  router.UnregisterReceiver(&receiver_);
+}
+
+TEST_F(LogRouterTest, ProcessLog_TwoReceiversNoUpdateAfterUnregistering) {
+  LogRouter router;
+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver_));
+  EXPECT_EQ(std::string(), router.RegisterReceiver(&receiver2_));
+
+  // Check that no logs are passed to an unregistered receiver.
+  router.UnregisterReceiver(&receiver_);
+  EXPECT_CALL(receiver_, LogSavePasswordProgress(_)).Times(0);
+  EXPECT_CALL(receiver2_, LogSavePasswordProgress(kTestText)).Times(1);
+  router.ProcessLog(kTestText);
+  router.UnregisterReceiver(&receiver2_);
+}
+
+}  // namespace password_manager