Password manager internals page service: introduction

components/password_manager/core/browser/log_router.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/password_manager/core/browser/log_router.h"
+
+#include "base/stl_util.h"
+#include "components/password_manager/core/browser/password_manager_client.h"
+#include "components/password_manager/core/browser/password_manager_logger.h"
+
+namespace password_manager {
+
+LogRouter::LogRouter() {
+}
+
+LogRouter::~LogRouter() {
+}

[Ilya Sherman, 2014/05/02 23:38:38]

nit: DCHECK that all listeners have unregistered?  (Not needed if you use
ObserverLists.)

[vabr (Chromium), 2014/05/06 13:16:30]

Done via using ObserverList with the right template argument.

+
+void LogRouter::ProcessLog(const std::string& text) {
+  if (!receivers_.empty()) {
+    accumulated_logs_.append(text);
+    for (ReceiverSet::iterator receiver = receivers_.begin();
+         receiver != receivers_.end();
+         ++receiver) {
+      (*receiver)->LogSavePasswordProgress(text);
+    }
+  }
+}
+
+bool LogRouter::RegisterClient(PasswordManagerClient* client) {
+  DCHECK(client);
+  if (ContainsKey(clients_, client))
+    return false;

[Ilya Sherman, 2014/05/02 23:38:38]

Can this be a DCHECK instead?

[vabr (Chromium), 2014/05/06 13:16:30]

Done via ObserverList.

+  clients_.insert(client);
+  // TODO(vabr): notify |client| about the activity state.
+  return true;
+}
+
+bool LogRouter::UnregisterClient(PasswordManagerClient* client) {
+  DCHECK(client);
+  ClientSet::iterator it = clients_.find(client);
+  if (it == clients_.end())
+    return false;

[Ilya Sherman, 2014/05/02 23:38:38]

Can this be a DCHECK instead?

[vabr (Chromium), 2014/05/06 13:16:30]

Switched to ObserverList, which actually does not do this check.
I could add that, but I don't actually have a strong need to.
Let me know if you would like me to restore that check (in which case I will do
it via DCHECK as suggested).

+  clients_.erase(it);
+  return true;
+}
+
+bool LogRouter::RegisterReceiver(PasswordManagerLogger* receiver) {
+  DCHECK(receiver);
+  DCHECK(accumulated_logs_.empty() || !receivers_.empty());
+
+  if (ContainsKey(receivers_, receiver))
+    return false;

[Ilya Sherman, 2014/05/02 23:38:38]

Can this be a DCHECK instead?

[vabr (Chromium), 2014/05/06 13:16:30]

Done via ObserverList.

+  if (receivers_.empty())
+    NotifyClients(ROUTER_ACTIVE);
+  receivers_.insert(receiver);
+  if (!accumulated_logs_.empty())
+    receiver->LogSavePasswordProgress(accumulated_logs_);
+  return true;
+}
+
+bool LogRouter::UnregisterReceiver(PasswordManagerLogger* receiver) {
+  DCHECK(receiver);
+  ReceiverSet::iterator it = receivers_.find(receiver);
+  if (it == receivers_.end())
+    return false;

[Ilya Sherman, 2014/05/02 23:38:38]

Can this be a DCHECK instead?

[vabr (Chromium), 2014/05/06 13:16:30]

Dropped. The same as in my response in UnregisterClient applies.

+  receivers_.erase(it);
+  if (receivers_.empty()) {
+    accumulated_logs_.clear();
+    NotifyClients(ROUTER_NOT_ACTIVE);
+  }
+  return true;
+}
+
+void LogRouter::NotifyClients(RouterActivityState state) {
+  for (ClientSet::iterator client = clients_.begin(); client != clients_.end();
+       ++client) {
+    // TODO(vabr): Pass |state| to |client|.
+  }
+}
+
+}  // namespace password_manager