Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2625823004: Support covariant keyword in the VM parser (Closed)

Created:
3 years, 11 months ago by hausner
Modified:
3 years, 11 months ago
Reviewers:
regis, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support covariant keyword in the VM parser For Dart 1.5, the VM ignores the annotation. It is just consumed by the parser, but has otherwise no effect. Errors are reported on illegal covariant declarations. BUG=#28166 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/90b937a4cee2a9c2295464be43f02edf1f9a1125

Patch Set 1 #

Patch Set 2 : wip #

Total comments: 1

Patch Set 3 : Fix tests that rely on token position #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -371 lines) Patch
M runtime/vm/method_recognizer.h View 9 chunks +297 lines, -297 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 12 chunks +38 lines, -1 line 0 comments Download
M runtime/vm/parser_test.cc View 1 2 11 chunks +26 lines, -26 lines 0 comments Download
M runtime/vm/token.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hausner
3 years, 11 months ago (2017-01-12 17:59:01 UTC) #3
regis
lgtm https://codereview.chromium.org/2625823004/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2625823004/diff/20001/runtime/vm/parser.cc#newcode3694 runtime/vm/parser.cc:3694: "methods and constructors cannot be declared covariant"); remove ...
3 years, 11 months ago (2017-01-12 18:17:58 UTC) #4
hausner
Committed patchset #3 (id:40001) manually as 90b937a4cee2a9c2295464be43f02edf1f9a1125 (presubmit successful).
3 years, 11 months ago (2017-01-12 22:03:33 UTC) #6
floitsch
3 years, 11 months ago (2017-01-13 14:54:53 UTC) #8
Message was sent while issue was closed.
thanks!

Powered by Google App Engine
This is Rietveld 408576698