Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2625813004: End the QUIC_SESSION net-log event at the end of the QuicChromiumClientSession (Closed)

Created:
3 years, 11 months ago by Ryan Hamilton
Modified:
3 years, 11 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

End the QUIC_SESSION net-log event at the end of the QuicChromiumClientSession destructor, instead of in the middle of a loop(?!) in the destructor. BUG=679968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/chromium/quic_chromium_client_session.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Ryan Hamilton
3 years, 11 months ago (2017-01-11 23:30:33 UTC) #2
xunjieli
+1. Thanks for fixing this so quickly! lgtm
3 years, 11 months ago (2017-01-11 23:33:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625813004/1
3 years, 11 months ago (2017-01-12 00:12:35 UTC) #5
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-12 03:08:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625813004/1
3 years, 11 months ago (2017-01-12 03:53:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/340355)
3 years, 11 months ago (2017-01-12 04:00:12 UTC) #12
Ryan Hamilton
3 years, 11 months ago (2017-01-26 22:54:12 UTC) #13
Weird! This CL actually already landed but this issue appears to not have been
updated or closed:

https://chromium.googlesource.com/chromium/src/+/532c355644c454315fd4d4ab879a...
 Cr-Commit-Position: refs/heads/master@{#443136}

Powered by Google App Engine
This is Rietveld 408576698